浏览代码

Remove unused num periods parameter

Chris Mullins 6 年之前
父节点
当前提交
c942ce60ed

+ 0 - 3
lib/MiLight/MiLightClient.cpp

@@ -605,9 +605,6 @@ bool MiLightClient::handleTransition(JsonObject args, JsonDocument& responseObj)
   if (args.containsKey(FS(TransitionParams::PERIOD))) {
   if (args.containsKey(FS(TransitionParams::PERIOD))) {
     transitionBuilder->setPeriod(args[FS(TransitionParams::PERIOD)]);
     transitionBuilder->setPeriod(args[FS(TransitionParams::PERIOD)]);
   }
   }
-  if (args.containsKey(FS(TransitionParams::NUM_PERIODS))) {
-    transitionBuilder->setNumPeriods(args[FS(TransitionParams::NUM_PERIODS)]);
-  }
 
 
   transitions.addTransition(transitionBuilder->build());
   transitions.addTransition(transitionBuilder->build());
   return true;
   return true;

+ 0 - 1
lib/MiLight/MiLightClient.h

@@ -29,7 +29,6 @@ namespace TransitionParams {
   static const char END_VALUE[] PROGMEM = "end_value";
   static const char END_VALUE[] PROGMEM = "end_value";
   static const char DURATION[] PROGMEM = "duration";
   static const char DURATION[] PROGMEM = "duration";
   static const char PERIOD[] PROGMEM = "period";
   static const char PERIOD[] PROGMEM = "period";
-  static const char NUM_PERIODS[] PROGMEM = "num_periods";
 }
 }
 
 
 // Used to determine RGB colros that are approximately white
 // Used to determine RGB colros that are approximately white

+ 0 - 1
lib/Transitions/ChangeFieldOnFinishTransition.cpp

@@ -15,7 +15,6 @@ ChangeFieldOnFinishTransition::Builder::Builder(
 
 
 std::shared_ptr<Transition> ChangeFieldOnFinishTransition::Builder::_build() const {
 std::shared_ptr<Transition> ChangeFieldOnFinishTransition::Builder::_build() const {
   delegate->setDurationRaw(this->getOrComputeDuration());
   delegate->setDurationRaw(this->getOrComputeDuration());
-  delegate->setNumPeriods(this->getOrComputeNumPeriods());
   delegate->setPeriod(this->getOrComputePeriod());
   delegate->setPeriod(this->getOrComputePeriod());
 
 
   return std::make_shared<ChangeFieldOnFinishTransition>(
   return std::make_shared<ChangeFieldOnFinishTransition>(

+ 0 - 5
lib/Transitions/Transition.cpp

@@ -26,11 +26,6 @@ Transition::Builder& Transition::Builder::setPeriod(size_t period) {
   return *this;
   return *this;
 }
 }
 
 
-Transition::Builder& Transition::Builder::setNumPeriods(size_t numPeriods) {
-  this->numPeriods = numPeriods;
-  return *this;
-}
-
 Transition::Builder& Transition::Builder::setDurationAwarePeriod(size_t period, size_t duration, size_t maxSteps) {
 Transition::Builder& Transition::Builder::setDurationAwarePeriod(size_t period, size_t duration, size_t maxSteps) {
   if ((period * maxSteps) < duration) {
   if ((period * maxSteps) < duration) {
     setPeriod(std::ceil(duration / static_cast<float>(maxSteps)));
     setPeriod(std::ceil(duration / static_cast<float>(maxSteps)));

+ 0 - 1
lib/Transitions/Transition.h

@@ -22,7 +22,6 @@ public:
 
 
     Builder& setDuration(float duration);
     Builder& setDuration(float duration);
     Builder& setPeriod(size_t period);
     Builder& setPeriod(size_t period);
-    Builder& setNumPeriods(size_t numPeriods);
 
 
     /**
     /**
      * Users are typically defining transitions using:
      * Users are typically defining transitions using: